Open
Conversation
dbogdan
previously approved these changes
Mar 2, 2026
amiclaus
reviewed
Mar 3, 2026
Contributor
There was a problem hiding this comment.
some comments on my side.
drivers/adc/ad4692/ad4692.c
Outdated
| } | ||
|
|
||
| init_param->conv_param->period_ns = MICRO; | ||
| case AD4692_CNV_CLOCK: /* fallthrough */ |
Contributor
There was a problem hiding this comment.
there's no fallthrough here. only abofer.
| if (ret) | ||
| pr_info("Error!\n"); | ||
| return ret; | ||
| } |
drivers/adc/ad4692/iio_ad4692.c
Outdated
| static int ad4692_iio_update_channels(void *desc, uint32_t mask) | ||
| { | ||
| struct ad4692_iio_desc *iio_ad4692; | ||
| uint32_t reg_val; |
Collaborator
Author
|
These drivers have to be updated due to revision change. |
21ba95e to
eed4a5a
Compare
Collaborator
Author
|
V2:
|
amiclaus
reviewed
Mar 6, 2026
Contributor
There was a problem hiding this comment.
is this ready for review?
Collaborator
Author
This PR is ready for review. |
96deec6 to
edccadb
Compare
Add initial header and source file for AD4692 no-OS driver. Signed-off-by: Radu Sabau <radu.sabau@analog.com>
Add initial header and source files for AD4692 IIO driver. Signed-off-by: Radu Sabau <radu.sabau@analog.com>
Add initial .rst documentation file for AD4692 driver. Signed-off-by: Radu Sabau <radu.sabau@analog.com>
Add initial project files for EVAL-AD4692-ARDZ board. Signed-off-by: Radu Sabau <radu.sabau@analog.com>
Add initial .rst documentation file for AD4692-ARDZ project. Signed-off-by: Radu Sabau <radu.sabau@analog.com>
edccadb to
3636dc5
Compare
Collaborator
Author
|
V3:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The AD4691/AD4692 are compact, high accuracy, 16-channel, 16-
bit successive approximation register (SAR) analog-to-digital con-
verters (ADCs) optimized for high-density multichannel precision
data acquisition solutions. The AD4691/AD4692 combine precision
performance with Easy Drive features and flexible digital processing
to ensure compatibility with space-constrained analog front-end
(AFE) designs and low-power digital hosts.
This PR contains commits for :
PR Type
PR Checklist