8000 Soft shutdown review comments 2 by BadSingleton · Pull Request #3 · amos402/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Soft shutdown review comments 2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2020
Merged

Soft shutdown review comments 2 #3

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b409a89
Check serializability of the whole type hierarchy
BadSingleton Sep 8, 2020
f5c24b0
Release the GIL on shutdown only if it can be released
BadSingleton Sep 8, 2020
0d6c645
Call `WaitForPendingFinalizers` instead
BadSingleton Sep 8, 2020
fa89b48
Revert local changes
amos402 Sep 9, 2020
80a7644
Remove unused code
amos402 Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert local changes
  • Loading branch information
@amos402 @BadSingleton
amos402 authored and BadSingleton committed Sep 10, 2020
commit fa89b487dd377bb0ae36a45cd41cb9da7f15bc8d
2 changes: 1 addition & 1 deletion src/runtime/typemanager.cs
View file Edit file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,7 +709,7 @@ private static void InitMethods(IntPtr pytype, Type type)
mi[0] = method;
MethodObject m = new TypeMethod(type, method_name, mi);
Runtime.PyDict_SetItemString(dict, method_name, m.pyHandle);
//m.DecrRefCount();
m.DecrRefCount();
addedMethods.Add(method_name);
}
}
Expand Down
0