Improve Convolution Filters #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch reworks the backend of all convolutional filters. It extracts the convolution logic out of `Convolve` and moves it into the new function `imgaug.augmenters.convolutional.convolve_()` (with non-in-place version `convolve()`). The logic is also reworked so that fewer convolution function calls and more in-place modification is used. This should lead to an improved performance. These changes also affect `Sharpen`, `Emboss`, `EdgeDetect`, `DirectedEdgeDetect` and `MotionBlur`. Add functions: * `imgaug.augmenters.convolutional.convolve_()` * `imgaug.augmenters.convolutional.convolve()`
Codecov Report
@@ Coverage Diff @@
## master #632 +/- ##
==========================================
+ Coverage 96.37% 96.37% +<.01%
==========================================
Files 41 41
Lines 14683 14698 +15
==========================================
+ Hits 14150 14165 +15
Misses 533 533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reworks the backend of all convolutional
filters. It extracts the convolution logic out of
Convolveand moves it into the new functionimgaug.augmenters.convolutional.convolve_()(withnon-in-place version
convolve()).The logic is also reworked so that fewer convolution
function calls and more in-place modification is
used. This should lead to an improved performance.
These changes also affect
Sharpen,Emboss,EdgeDetect,DirectedEdgeDetectandMotionBlur.Add functions:
imgaug.augmenters.convolutional.convolve_()imgaug.augmenters.convolutional.convolve()