Vectorize CropAndPad #619
Merged
Vectorize CropAndPad #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch vectorizes parts of `CropAndPad`, especially the sampling process, leading to an improved performance for large batches. Previously, cropping an image below a height and/or width of `1` would be prevented by `CropAndPad` *and* a warning was raised if it was tried. That warning was now removed, but height/width of at least `1` is still ensured.
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 96.35% 96.41% +0.06%
==========================================
Files 41 41
Lines 14670 15137 +467
==========================================
+ Hits 14134 14593 +459
- Misses 536 544 +8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch vectorizes parts of
CropAndPad, especially thesampling process, leading to an improved performance for large
batches.
Previously, cropping an image below a height and/or width of
1would be prevented byCropAndPadand a warning wasraised if it was tried. That warning was now removed, but
height/width of at least
1is still ensured.