docs: improve EventStream doc #32348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bce1e99 to
5e44c38
Compare
5e44c38 to
e8be86e
Compare
johanandren
reviewed
May 3, 2024
Contributor
There was a problem hiding this comment.
Not convinced this improves much on the existing docs
| val adapter = context.messageAdapter[DeadLetter](d => d.message.toString) | ||
| def apply(): Behavior[DeadLetter] = Behaviors.setup { context => | ||
| // subscribe DeadLetter at start up. | ||
| val adapter = context.messageAdapter[DeadLetter](d => d) |
Contributor
There was a problem hiding this comment.
No need for an adapter then, if the actor already accepts DeadLetter
acbfbc0 to
7747bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some improvements for event stream documentation, maybe it isn't necessary?