feat: Increase default stdio buffer limit and allow configuration #59
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for your PR. The default 50MB limit doesn't seem reasonable. I think it's sufficient to just allow it to be configured. |
|
@PsiACE I would at least increase the default limit to at least 1MB or sth.. its quite easy to reach the 64kb when it comes to sending the models and slash commands (model lists can easily reach 1000 items for some agents) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4A50
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The default stdio stream buffer size is only 64kb, which means you get errors like this when trying to send messages larger than that via ACP:
Filesizes above that are quite common for multimodal data
The new default of 50MB should handle most practical multimodal cases. Definitely open to tweaking this default though if anyone has strong feelings! And it's now configurable if needed
Related issues
Testing
Added tests and ran appropriate make commands
Docs & screenshots
Not sure how to best document, assuming this will automatically propagate to API refs?
Checklist
feat:,fix:).make gen-all) are called out if applicable.