Check for presence of UniformsLib/Utils instead of importing them from three/src #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for checking that. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
To support the
WebGPURendererof three.js, some modifications were made tomsdf.jsandsdf.js(#5655). By importing fromthree/src/directly a different copy is being included into the bundle. This extended to various Color/Matrix/Vector classes as well. Functionally this didn't cause any problems AFAICT, but it did bloat the bundle size (~19kiB to the minified build).This PR replaces the imports with a check if they exist instead. This does mean that the fog uniforms are missing when using the
WebGPURenderer, but these shaders currently don't work withWebGPURendereranyway and even if they did, fog is handled differently when using it.Changes proposed:
UniformsUtils/UniformsLibexist instead of importing them fromthree/src/