8000 Added support for AwesomeAssertions fork by msmolka · Pull Request #144 · adrianiftode/FluentAssertions.Web · GitHub
[go: up one dir, main page]
Skip to content

Added support for AwesomeAssertions fork #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2025
Merged

Added support for AwesomeAssertions fork #144

merged 2 commits into from
Jun 9, 2025

Conversation

msmolka
Copy link
Contributor
@msmolka msmolka commented Jun 7, 2025

Here a work, to add support for FluentAssertions fork: AwesomeAssertions

adrianiftode
adrianiftode requested changes Jun 9, 2025
View reviewed changes
Copy link
Owner
@adrianiftode adrianiftode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your PR. Although I didn't really want to create another switch, I think it looks ok, not too bad to maintain. There are some comments if you can take a look. Thanks again

@adrianiftode adrianiftode merged commit 1265902 into adrianiftode:master Jun 9, 2025
1 check passed
@adrianiftode
Copy link
Owner
adrianiftode commented Jun 9, 2025 •
edited
Loading

I merged it, but having some issues to upload it to nuget as AwesomeAssertions prefix is reserved. Will wait for the team to make a decision regarding this, otherwise we'll have to think on a nuget name

AwesomeAssertions/AwesomeAssertions#177 (comment)

@msmolka
Copy link
Contributor Author
msmolka commented Jun 9, 2025

I'm afraid I'm not an owner of repo. Just contributed here. :) I hope we will get approval for name

@msmolka msmolka mentioned this pull request Jun 9, 2025
Closed
@kasperk81
Copy link

https://www.nuget.org/packages/AwesomeAssertions.Web 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianiftode adrianiftode adrianiftode requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msmolka @adrianiftode @kasperk81
0