Use Central Package Management #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using custom <Import Project=...> use the standard [Central Package Management](https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management) mechanism.
> warning NU1507: There are 3 package sources defined in your configuration. When using central package management, please map your package sources with package source mapping (https://aka.ms/nuget-package-source-mapping) or specify a single package source. The following sources are defined: nuget.org, AnotherSource, YetAnotherSource
> warning NU1903: Package 'Newtonsoft.Json' 10.0.1 has a known high severity vulnerability, GHSA-5crp-9r3c-p9vr
Something apparently changed in the runtime when boxing enums values with multiple definitions sharing the same values such as HttpStatusCode. E.g. HttpStatusCode.Ambiguous == HttpStatusCode.MultipleChoices == 300
adrianiftode
previously approved these changes
Nov 24, 2024
|
Looks great, thanks! Do you mind not targeting NET9.0 yet? AppVeyor did not yet update their build image https://www.appveyor.com/docs/windows-images-software/#visual-studio-2022 |
|
I've closed #124, we can merge this one. |
|
I just removed .NET 9 support in eb40ffc, let's see how it goes on AppVeyor. |
|
I also had to remove .NET 5 and now everything is ✅ on AppVeyor. |
|
Many thanks, Cédric! A new release is on the way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using custom
<Import Project=…>use the standard Central Package Management mechanism.Also add tests on .NET 8 and 9 and fix many warnings.
I should have looked at existing pull requests first because there's some overlap with #124.