8000 Fix typo: originated -> originating by cmeeren · Pull Request #115 · adrianiftode/FluentAssertions.Web · GitHub
[go: up one dir, main page]
Skip to content

Fix typo: originated -> originating #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fix typo: originated -> originating #115

merged 1 commit into from
Jan 4, 2023

Conversation

cmeeren
Copy link
@cmeeren cmeeren commented Jan 4, 2023

No description provided.

@adrianiftode
Copy link
Owner

Thank you for your contribution. My intention with the originated is to put the stress on what HTTP request initiated the HTTP request - response sequence. Original to me seems something that is the start of a group of HTTP requests and not necessarily for one single pair of HTTP request and response (I am not a native English speaker and neither an English proficient so I can't really tell though if originated is an issue)

@cmeeren
Copy link
Author
cmeeren commented Jan 4, 2023

Ok, a better term then is originating. I will change the PR to that instead.

@cmeeren
Copy link
Author
cmeeren commented Jan 4, 2023

Done.

@adrianiftode adrianiftode changed the title Fix typo: originated -> original Fix typo: originated -> originating Jan 4, 2023
@adrianiftode adrianiftode merged commit 990769b into adrianiftode:master Jan 4, 2023
@adrianiftode
Copy link
Owner

I will release it with other changes in the following days

@cmeeren cmeeren deleted the fix-typo branch January 4, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianiftode adrianiftode adrianiftode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmeeren @adrianiftode
0