8000 IMPROVEMENT: Networking by adamayoung · Pull Request #171 · adamayoung/TMDb · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVEMENT: Networking #171

Merged
merged 35 commits into from
May 1, 2024
Merged

IMPROVEMENT: Networking #171

merged 35 commits into from
May 1, 2024

Conversation

adamayoung
Copy link
Owner

No description provided.

Copy link
codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 96.36608% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 88.83%. Comparing base (17d8ace) to head (b749b51).

Files Patch % Lines
...rces/TMDb/Domain/APIClient/CodableAPIRequest.swift 55.55% 12 Missing ⚠️
Sources/TMDb/Networking/TMDbAPIClient.swift 84.78% 7 Missing ⚠️
Sources/TMDb/Extensions/URL+QueryItem.swift 16.66% 5 Missing ⚠️
Sources/TMDb/TMDbFactory.swift 0.00% 2 Missing ⚠️
...es/TMDb/Domain/APIClient/APIRequestQueryItem.swift 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   88.41%   88.83%   +0.42%     
==========================================
  Files         109      165      +56     
  Lines        2288     2428     +140     
==========================================
+ Hits         2023     2157     +134     
- Misses        265      271       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamayoung adamayoung merged commit c32b6fd into main May 1, 2024
16 checks passed
@adamayoung adamayoung deleted the feature/networking-improvements branch May 1, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0