8000 Add test that the resulting repo is pre-commit clean by jepler · Pull Request #245 · adafruit/cookiecutter-adafruit-circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Add test that the resulting repo is pre-commit clean #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2025
Merged

Add test that the resulting repo is pre-commit clean #245

merged 1 commit into from
Jan 13, 2025

Conversation

jepler
Copy link
Contributor
@jepler jepler commented Jan 13, 2025

Once #243 is merged, I will rebase & force-push this. At that point the test should pass.

@jepler jepler force-pushed the test-cookie-pylint-clean branch from 9b5d363 to 55f6d04 Compare January 13, 2025 21:27
@jepler jepler changed the title Add (failing) test that the resulting repo is pre-commit clean Add test that the resulting repo is pre-commit clean Jan 13, 2025
@jepler
Copy link
Contributor Author
jepler commented Jan 13, 2025

In the failed run (before #243) this errored, as expected:


pre-commit hook(s) made changes.
If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/docs/conf.py b/docs/conf.py
index 8878a8c..ebbcca9 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -32,8 +32,6 @@ autodoc_preserve_defaults = True
 
 intersphinx_mapping = {
     "python": ("https://docs.python.org/3", None),
-    
-    
     "CircuitPython": ("https://docs.circuitpython.org/en/latest/", None),
 }

now it is green,because there aren't any pre-commit problems detected in the freshly cookie-cut libs anymore.

@jepler jepler requested a review from FoamyGuy January 13, 2025 21:50
FoamyGuy
FoamyGuy approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor
@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you! It'll be nice to have this validated by actions.

@FoamyGuy FoamyGuy merged commit 2e4f5e5 into main Jan 13, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @FoamyGuy
0