Add timeout-minutes to adabot.update_cp_org_libraries action task #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would serve as sort of "relief valve" for the long stalled actions task. The configuration is documented here: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes making it give up and get cancelled sooner if it gets stalled.
The default value is 360 which matches the 6 hours that the actions run lasts when it gets stalled.
I believe with it set to 150 minutes it should get cancelled and stopped after 2.5 hours maximum instead of 6 hours.
2.5 hours was selected to account for up to 2 of the 1hour wait intervals for API rate limit. I believe that should make it so that along with the fix from adafruit/adabot#397 this should always be able to finish in under 2.5 hours under normal circumstances. The changes from this Adabot PR cap the time it will sleep for to 63 minutes, and it seems like it gets to around 60 minutes in and the negative overflow sleep logic makes it stall for the remainder of the 6 hours when that does happen, so In the same root cause scenario it could get to 60ish minutes, have the overflowed sleep, but with the new logic only sleep for 63 minutes instead, leaving around 30 minutes afterward to be able to finish within the new 2.5 hour limit.