8000 Update tlsf by tannewt · Pull Request #9004 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Update tlsf #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update tlsf #9004

merged 1 commit into from
Mar 5, 2024

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Mar 5, 2024

The original implementation couldn't allocate to a region that was just freed even though the freed region was the same size as the new request. This was due to allocation sizes being rounded up during search but not when marking the region in use.

Fixes adafruit/Adafruit_Learning_System_Guides#2746

@tannewt
Update tlsf
f6aa7b1 
The original implementation couldn't allocate to a region that was
just freed even though the freed region was the same size as the
new request. This was due to allocation sizes being rounded up
during search but not when marking the region in use.

Fixes adafruit/Adafruit_Learning_System_Guides#2746
@tannewt tannewt requested a review from dhalbert March 5, 2024 00:22
@tannewt tannewt mentioned this pull request Mar 5, 2024
Merged
dhalbert
dhalbert approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, fantastic!

@dhalbert
Copy link
Collaborator
dhalbert commented Mar 5, 2024

Are you going to PR this upstream?

@dhalbert dhalbert merged commit 4a335af into adafruit:main Mar 5, 2024
@tannewt
Copy link
Member Author
tannewt commented Mar 5, 2024

Yup! espressif/tlsf#2

@mikeysklar
Copy link
mikeysklar commented Mar 8, 2024 •
edited
Loading

The Feather DVI hello world example gets much further with the first CP9.x release candidate that dropped today.

It eventually runs out of memory in sine_chart() after a few loops, but does complete all of the demo code.

Adafruit CircuitPython 9.0.0-rc.0 on 2024-03-08; Adafruit Feather RP2040 DVI with rp2040
>>>
soft reboot

Auto-reload is on. Simply save files over USB to run them or enter REPL to disable.
code.py output:
Traceback (most recent call last):
  File "code.py", line 328, in <module>
  File "code.py", line 160, in widget0
  File "adafruit_display_shapes/line.py", line 54, in __init__
  File "adafruit_display_shapes/polygon.py", line 69, in __init__
MemoryError: memory allocation failed, allocating 940 bytes

Code done running.

Adafruit CircuitPython 9.0.0-rc.0 on 2024-03-08; Adafruit Feather RP2040 DVI with rp2040

@mikeysklar
Copy link

Update...Without making any changes I've been able to run the demo for over 40 minutes without issue.

The MemoryError I had seen seems fleeting like what @BlitzCityDIY encountered earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DVI_Hello_World - Out of Memory
3 participants
@tannewt @dhalbert @mikeysklar
0