Human readable OSError messages for low flash devices #891

godlygeek · 2018-06-01T22:46:28Z

#837 implemented human readable OSError messages, but excluded low-flash devices (ones with BOARD_FLASH_SIZE <= 192000).

This PR improves the situation on those devices:

Adafruit CircuitPython 3.0.0-beta.0-32-gd6ff451-dirty on 2018-06-01; Adafruit Gemma M0 with samd21e18
>>> for i in range(32): print(OSError(i))
...
[Errno 0]
[Errno 1] EPERM
[Errno 2] ENOENT
[Errno 3]
[Errno 4]
[Errno 5] EIO
[Errno 6]
[Errno 7]
[Errno 8]
[Errno 9]
[Errno 10]
[Errno 11] EAGAIN
[Errno 12] ENOMEM
[Errno 13] EACCES
[Errno 14]
[Errno 15]
[Errno 16]
[Errno 17] EEXIST
[Errno 18]
[Errno 19] ENODEV
[Errno 20]
[Errno 21] EISDIR
[Errno 22] EINVAL
[Errno 23]
[Errno 24]
[Errno 25]
[Errno 26]
[Errno 27]
[Errno 28]
[Errno 29]
[Errno 30]
[Errno 31]

On devices with low flash, we still won't create the uerrno module. Instead, we'll create a utility method that knows how to map each of the errno's that we can raise to its name. In order to save flash, we also prune the list of errno's that the utility method must know about down to just the subset that can be raised on atmel-samd.

We can provide a basic version of mp_errno_to_str even if the uerrno module won't be provided. Rather than looking errno names up in the uerrno module's globals dict, we'll just rely on a simple mapping in the function itself.

The uerrno module was written to allow boards to customize the list of errnos they can raise. Start by copying the default list.

Remove errnos that are only raised by modules that aren't linked into the atmel-samd port.

tannewt

Yay! This looks great. Nice and clean. Thank you!

godlygeek force-pushed the low_flash_errno_fixes branch from b97cfdd to 0f4280a Compare June 1, 2018 22:50

godlygeek added 3 commits June 1, 2018 19:03

Provide mp_errno_to_str even without uerrno

1c35dbf

We can provide a basic version of mp_errno_to_str even if the uerrno module won't be provided. Rather than looking errno names up in the uerrno module's globals dict, we'll just rely on a simple mapping in the function itself.

Begin a custom list of errnos for atmel-samd

e798b67

The uerrno module was written to allow boards to customize the list of errnos they can raise. Start by copying the default list.

Prune atmel-samd errno list

22f4438

Remove errnos that are only raised by modules that aren't linked into the atmel-samd port.

godlygeek force-pushed the low_flash_errno_fixes branch from 0f4280a to 22f4438 Compare June 1, 2018 23:04

Use the system errno's on nrf

d0e6bb2

tannewt self-requested a review June 5, 2018 00:20

tannewt added this to the 3.0 milestone Jun 5, 2018

tannewt added enhancement atmel-samd labels Jun 5, 2018

tannewt approved these changes Jun 5, 2018

View reviewed changes

tannewt merged commit 0c7c082 into adafruit:master Jun 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Human readable OSError messages for low flash devices #891

Human readable OSError messages for low flash devices #891

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Human readable OSError messages for low flash devices #891

Human readable OSError messages for low flash devices #891

Uh oh!

Conversation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!