8000 Boost flash and RAM speeds on ESP boards by tannewt · Pull Request #8870 · adafruit/circuitpython · GitHub
[go: up one dir, main page]

Skip to content

Boost flash and RAM speeds on ESP boards #8870

New issue

Have a question about this project? Sign up for a f 8000 ree GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Jan 31, 2024

We inherited a bunch of DIO from 8.x which used it for ROM flash settings. Pretty much everything should be able to do QIO.

S2, S3 and ESP32 all support 80mhz as well and ESP modules tend to work at that speed too. Only on ESP32 do we leave PSRAM at 40mhz because the 80/80 mode uses an extra SPI resource that we don't want to use.

Fixes #8612

Smoke tested on Adafruit Feather S2 with 4MB flash and 2MB ram. No other boards tested. We can back out these changes if boards have trouble with them.

We inherited a bunch of DIO from 8.x which used it for ROM flash
settings. Pretty much everything should be able to do QIO.

S2, S3 and ESP32 all support 80mhz as well and ESP modules tend to
work at that speed too. Only on ESP32 do we leave PSRAM at 40mhz
because the 80/80 mode uses an extra SPI resource that we don't
want to use.

Fixes micropython#8612
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be OK.

I'll note that after I filed #8612, I made some of these changes on a few boards, and was unable to quantify any speedup whatsoever with short and long (e.g. say 30 lines of code) loops.

@dhalbert dhalbert merged commit 09fcc59 into adafruit:main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check CIRCUITPY_ESP_FLASH_MODE settings on Espressif boards
2 participants
0