8000 Switch to using SPIRAM through caps_alloc by tannewt · Pull Request #8868 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Switch to using SPIRAM through caps_alloc #8868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

Switch to using SPIRAM through caps_alloc #8868

merged 1 commit into from
Feb 7, 2024

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Jan 31, 2024

We used to default to malloc() using SPIRAM but it disables dynamic WiFi TX buffers. The increased static buffer allocation prevents MBEDTLS from allocating everything it needs. So, switch the IDF to SPIRAM through caps_alloc only. This is pretty much what we do in CP8 except we no longer need to explicitly give the IDF SPIRAM memory to use.

Fixes #8682 (again)

@tannewt
Switch to using SPIRAM through caps_alloc
8ceeb4d 
We used to default to `malloc()` using SPIRAM but it disables
dynamic WiFi TX buffers. The increased static buffer allocation
prevents MBEDTLS from allocating everything it needs. So, switch
the IDF to SPIRAM through caps_alloc only. This is pretty much what
we do in CP8 except we no longer need to explicitly give the IDF
SPIRAM memory to use.

Fixes micropython#8682 (again)
@tannewt tannewt added this to the 9.0.0 milestone Jan 31, 2024
@tannewt tannewt requested a review from jepler January 31, 2024 20:59
dhalbert
dhalbert approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did not test.

@dhalbert dhalbert merged commit 7ba62bb into adafruit:main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

espidf memory error with 9.0 alpha.5
2 participants
@tannewt @dhalbert
0