cyw43-driver: Update to Adafruit fork #8861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing CI checks are due to Russian M0 flash overflow and are not related to this pull. Requesting review. |
|
Not ready for review, not picking up the correct submodule branch. |
|
Now picking up the correct submodule branch. Word to the wise: Update both Please review. |
anecdata
reviewed
Jan 30, 2024
There was a problem hiding this comment.
I'll leave code review to someone else, but tested with the code in #8718 (comment), and it looks good: any sequence of starting or stopping station or AP works now. Simultaneous station + AP is fine.
tannewt
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
cyw43-driverto branchcircuitpython9of the Adafruit fork. This updatescyw43-driverto its upstreamMAINplus two patches awaiting upstream merge.This pull resolves #8718.