-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add new board: Cytron EDU PICO #8800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems that the error occur due to the new submodule libraries is still not available. Do I need to PR the new submodule libraries first before adding the board? |
It looks to me like you added the submodules to (I thought at first it was due to an obsolete GitHub Actions cache, but I deleted that cache entry, and it still didn't work.) |
Looking over the product information it looks to me like this board would work with either the Pico or the Pico W. It seems like the plan is to market it for use with the Pico W but you might want to allow for a future version of the CircuitPython firmware built for the Pico by renaming this port to "Cytron EDU PICO W" and updating MICROPY_HW_BOARD_NAME and possibly The Pico version would be very similar to the Pico W. A simpler mpconfigboard.mk and a few changes to pins.c (including the LED definition). |
Thank you, it's working. It seems I missed the step to do a |
After some discussion, renaming this port to "Cytron EDU PICO W" would be a better option. Thank you for foreseeing this option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I don't have the hardware to test but I did load the artifact up on a Pico W and it seems to work fine (except for Web Workflow but I think that may be related to a separate issue reported in a current discord thread, WiFi works fully except for the Web Workflow page, tomorrow I'll see how reproducible the problem is and if I can track it to a particular merge).
I don't think the web workflow issue should hold up this merge. I'm seeing the same problem if I replace the artifact from this PR with the 9.0.0 alpha 6 from circuitpython.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both!
Thanks a lot, you all. |
Hi, can you please help to add this new board?
https://www.cytron.io/p-edu-project-and-innovation-kits-for-pico-w
and also adding new submodule libraries.
Thanks.