esp8266/modutime.c: remove symbol conflicts between time and utime modules #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dules this renames symbols in modutime.c so that it no longer conflicts with the time module. This commit does not enable the utime module; it simply makes it easier for a local developer to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this renames symbols in
modutime.cso that it no longer conflicts withthe
timemodule. This commit does not enable the utime module; itsimply makes it easier for a local developer to do so.
I understand that there is no intention of including
utimein theCircuitPython build and I'm not suggesting that we do that. I'm only
hoping to make it easier for someone to enable this module if they
require it for micropython compatibility.
I guess the alternative would be to simply remove
modutime.c.