8000 restore nvm module by jepler · Pull Request #7014 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

restore nvm module #7014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2022
Merged

restore nvm module #7014

merged 2 commits into from
Oct 7, 2022

Conversation

jepler
Copy link
@jepler jepler commented Oct 6, 2022

Closes: #7013

dhalbert
dhalbert previously approved these changes Oct 6, 2022
View reviewed changes
@jepler
8000 Copy link
Author
jepler commented Oct 6, 2022

sadly, it doesn't fit.

@dhalbert
Copy link
Collaborator
dhalbert commented Oct 6, 2022

sadly, it doesn't fit.

Let's make this draft and merge when it will fit.

@dhalbert dhalbert marked this pull request as draft October 6, 2022 18:48
@microdev1
Copy link
Collaborator

sadly, it doesn't fit.

I turned off rainbowio on arduino_zero in my storage extension PR. f44288d

@microdev1 microdev1 marked this pull request as ready for review October 7, 2022 14:34
microdev1
microdev1 reviewed Oct 7, 2022
View reviewed changes
Copy link
Collaborator
@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhalbert Your commit 66f6d8e includes esp-idf submodule update.

@dhalbert
Copy link
Collaborator
dhalbert commented Oct 7, 2022

@dhalbert Your commit 66f6d8e includes esp-idf submodule update.

Ugh, sorry, I was doing esp-idf bisecting in the same clone. Too much muscle memory: git commit -a -m instead of git commit -m.

@dhalbert dhalbert force-pushed the restore-nvm-module branch from 66f6d8e to 78b278e Compare October 7, 2022 14:42
@microdev1 microdev1 merged commit fc549fe into adafruit:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microdev1 microdev1 microdev1 approved these changes

@dhalbert dhalbert dhalbert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nvm module cannot be imported
3 participants
@jepler @dhalbert @microdev1
0