rp2pio: fix occasional bug when not using OUT pins #6863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a NULL first pin object is used to indicate that there are zero of some kind of pin associated with the StateMachine. However, mask_and_rotate wasn't checking for zero. It actually read data from near address 0x0 and (in my case) got a nonzero mask, which then caused a program with GPIO11 and GPIO12 as input with pull-up and no out pins to erroneously encounter the error "pull masks conflict with direction masks"
dhalbert
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a NULL first pin object is used to indicate that there are zero of some kind of pin associated with the StateMachine. However, mask_and_rotate wasn't checking for zero. It actually read data from near address 0x0 and (in my case) got a nonzero mask, which then caused a program with GPIO11 and GPIO12 as input with pull-up and no out pins to erroneously encounter the error "pull masks conflict with direction masks"