matrixportal: remove ulab to make room to freeze portalbase #6779
Conversation
|
Looking at that issue I wrote - it looks like something I did proxy style for something someone brought up in the forums. But I didn't add a forum link unfortunately. It may have been nothing more than someone working through that one Learn page and hitting the import error. If there's no current Learn project that uses BLE with MP, then I guess this can be a design choice for the CP devs. I think it'd be neat to leave it in if possible. Could make projects that use the Connect app to interact in some way, etc. - which would be peripheral mode. Similar to this project. But if there's a design choice to remove it, then definitely should hide that Learn page and anything else that indicates BLE is supported on the MP CP build. |
|
@ladyada I discussed this with @caternuson on discord. He suggested there were more potential projects the would use BLE (see above for an example) than |
|
@jepler Adding you as a reviewer. Current choice of disabling ulab is based on discussion at end of Monday's meeting. |
|
Thanks! |
|
Is there an alternative method for using |
As per the discussion we had at the time, we figured if anybody needed it, a custom build of CircuitPython would work (though you'd probably have to disable BLE in its stead). Perhaps when adafruit/Adafruit_CircuitPython_PortalBase#59 is addressed (depending on results), it might be able to get optimized enough to allow adding both. I have some doubts about that though as the primary focus would be on memory usage, but removing the bloat might be enough to help. |
|
Thanks. Good to know. I’ll stick with 7.3.2 and will place a note in PaletteFader to warn users. A note in CircuitPython.org would be helpful to bring attention to the one-off incompatibility. Is there a possibility of creating a ulab library instead? |
|
This discussion reminds me of https://learn.adafruit.com/ocean-epoxy-resin-lightbox-with-rgb-led-matrix-image-scroller/circuitpython-code -- it was coded before matrixportal, but does use ulab & rgbmatrix together. |
... and was the inspiration for the palette calculation portion of PaletteFader. Thank you @jepler and @ladyada!. Also, ulab was fundamentally useful for the bilinear interpolation method in https://learn.adafruit.com/improved-amg8833-pygamer-thermal-camera. I've been trying to use ulab in my projects whenever possible. |
adafruit_portalbaseas a frozen library.We've removed and then replaced BLE support in MatrixPortal once already:
I think it was restored because the MatrixPortal Guide included the standard mirrored AirLift BLE page. However, I see no Learn Guide projects that use it. We can hide or remove that page in the Guide.
@caternuson (author of #6152) Do you know of any specific reason why we need BLE support in MatrixPortal? Note that the AirLift BLE support only supports acting as a BLE peripheral, not a central.
@makermelissa tagging you for interest and any comment you have.