Add Waveshare ESP32-S2-Pico #6672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Board picture |
|
Thanks for the PR! You can probably get an Espressif PID here: https://github.com/espressif/usb-pids/blob/main/allocated-pids.txt |
|
From the support ticket, I got the official values. |
tannewt
reviewed
Aug 2, 2022
|
I have no idea what is wrong with the github actions. Should changes be needed, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I am not affiliated with waveshare in any way.
All board functions are working as intended.
My only concern is the USB_VID & USB_PID.
Waveshare hasn't provided official values and I stole the ones you see from Waveshare RP2040 Zero.
I have opened a support ticket to waveshare and this issue is also tracked in the tinyuf2 port pr.
(Ljinux is a wanna-be operating system that runs on top of circuitpython and is a very good benchmark)