8000 Remove obsolete peripheral drivers in esp module by dhalbert · Pull Request #641 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Remove obsolete peripheral drivers in esp module #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2018
Merged

Remove obsolete peripheral drivers in esp module #641

merged 1 commit into from
Feb 23, 2018

Conversation

dhalbert
Copy link
Collaborator

Fixes #639. There was old support for dht, ds18x20 (OneWire temp sensor), apa102, and neopixel in the esp module. These are now handled by SPI, OneWire, bitbang, and the native neopixel_write module.

@dhalbert dhalbert requested a review from tannewt February 23, 2018 16:02
@ladyada
Copy link
Member
ladyada commented Feb 23, 2018

yes! reviewed and looks good to me - i can merge if you want - or you can wait for tannewt

tannewt
tannewt approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Sorry I broke it.

@tannewt tannewt merged commit 892d5cd into adafruit:2.x Feb 23, 2018
@dhalbert dhalbert deleted the 2.x_esp8266_remove_obsolete_drivers branch February 23, 2018 21:36
@dhalbert dhalbert mentioned this pull request Feb 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @ladyada @tannewt
0