8000 Document TileGrid limitation to tile values 0..255 & improve mp3 doc by jepler · Pull Request #6245 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Document TileGrid limitation to tile values 0..255 & improve mp3 doc #6245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2022
Merged

Document TileGrid limitation to tile values 0..255 & improve mp3 doc #6245

merged 2 commits into from
Apr 6, 2022

Conversation

jepler
Copy link
@jepler jepler commented Apr 5, 2022 •
edited
Loading

Closes #6149. Closes #6133.

@jepler
Copy link
Author
jepler commented Apr 5, 2022

That's not to say we shouldn't improve tilegrid in the future!

dhalbert
dhalbert previously approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noting this!

@jepler jepler changed the title Document TileGrid limitation to tile values 0..255 Document TileGrid limitation to tile values 0..255 & improve mp3 doc Apr 5, 2022
dhalbert
dhalbert previously approved these changes Apr 5, 2022 8000
View reviewed changes
@jepler jepler force-pushed the document-tilegrid-8bit branch from 7acd88b to c89af99 Compare April 5, 2022 19:50
FoamyGuy
FoamyGuy reviewed Apr 5, 2022
View reviewed changes
Copy link
Collaborator
@FoamyGuy FoamyGuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran into this TileGrid limitation yesterday as well and looked into the code and came to the same conclusion about the 255 limit. Thank you for adding some mention of it to the docs.

It might be worth documenting this limit on the __setitem__ docstring down here as well:

circuitpython/shared-bindings/displayio/TileGrid.c

Line 389 in 359d8e5

//| def __setitem__(self, index: Union[Tuple[int, int], int], value: int) -> None:
This is one of the places I looked before going into the code.

dhalbert
dhalbert approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit 85ce161 into adafruit:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy left review comments

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

displayio.TileGrid does not document limitation to 255 frames RP2040 mp3 playback is static
3 participants
@jepler @FoamyGuy @dhalbert
0