10000 Enable support for extended HID usage page and usage. Related to Supp… by ReeceRobinson · Pull Request #6239 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Enable support for extended HID usage page and usage. Related to Supp… #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2022
Merged

Enable support for extended HID usage page and usage. Related to Supp… #6239

merged 3 commits into from
Apr 5, 2022

Conversation

ReeceRobinson
Copy link
@ReeceRobinson ReeceRobinson commented Apr 5, 2022 •
edited by dhalbert
Loading

Enable support for extended HID usage page and usage. Related to Support HID Usage Pages and Usages >255 #5529.
Also added suppression for array-bounds warning to enable mpy-cross to build on Mac.

Fixes #5529 (EDIT by @dhalbert for automatic linkage to issue)

@ReeceRobinson ReeceRobinson mentioned this pull request Apr 5, 2022
Closed
@dhalbert
Copy link
Collaborator
dhalbert commented Apr 5, 2022

Build failures are CI - not related to PR.

dhalbert
dhalbert requested changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I will make the one change noted and then re-run.

@dhalbert
Copy link
Collaborator
dhalbert commented Apr 5, 2022

I fixed a minor build problem to make sure this works for all builds including espressif. Will merge when done.

@dhalbert
Copy link
Collaborator
dhalbert commented Apr 5, 2022 •
edited
Loading

The CI jobs vary about which versions of typer and click they are loading, which is causing failures. The most current versions should be fine.

EDIT: pypi is having issues, according to https://status.python.org/.

@dhalbert dhalbert merged commit 7ad35bf into adafruit:main Apr 5, 2022
@ReeceRobinson
Copy link
Author

Awesome! Thank you Dan for resolving the issues to get this merged. Your efforts made it easy for me to contribute to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HID Usage Pages and Usages >255
2 participants
@ReeceRobinson @dhalbert
0