8000 update TileGrid docstrings to include OnDiskBitmap by FoamyGuy · Pull Request #5285 · adafruit/circuitpython · GitHub
[go: up one dir, main page]

Skip to content

update TileGrid docstrings to include OnDiskBitmap #5285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

FoamyGuy
Copy link
Collaborator
@FoamyGuy FoamyGuy commented Sep 2, 2021

On #5280 @lesamouraipourpre correctly pointed out that OnDiskBitmap is also a valid type for the first argument of the TileGrid constructor.

This addes OnDiskBitmap in the docstrings for TileGrid so that IDEs will not report an error when circuitpython-stubs are installed. Tested by running make stubs and installing them locally.

Copy link
Collaborator
@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@microdev1 microdev1 merged commit d49c5d6 into adafruit:main Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0