8000 Update the idf to a newer 4.3 commit by tannewt · Pull Request #5250 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Update the idf to a newer 4.3 commit #5250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2021
Merged

Update the idf to a newer 4.3 commit #5250

merged 1 commit into from
Aug 28, 2021

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Aug 27, 2021

Also, make all port-level CIRCUITPY_ settings overridable.

@tannewt
Update the idf to a newer 4.3 commit
ca989c4 
Also, make all port-level CIRCUITPY_ settings overridable.
@tannewt tannewt added this to the 7.0.0 milestone Aug 27, 2021
@tannewt tannewt requested a review from microdev1 August 27, 2021 17:50
jepler
jepler approved these changes Aug 27, 2021
View reviewed changes
Copy link
@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked that the only modification we had was taken upstream as well, d97b6863badec4643bf8d1d1058a65d723572882

@microdev1 microdev1 added enhancement espressif applies to multiple Espressif chips labels Aug 27, 2021
microdev1
microdev1 approved these changes Aug 27, 2021
View reviewed changes
Copy link
Collaborator
@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@tannewt tannewt merged commit f71d9e0 into adafruit:main Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

@microdev1 microdev1 microdev1 approved these changes

Assignees
No one assigned
Labels
enhancement espressif applies to multiple Espressif chips
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @jepler @microdev1
0