Update various Trinkey pins and add _pixelbuf #4765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eabb8e3 to
6fc836c
Compare
6fc836c to
6a2ba83
Compare
ladyada
previously approved these changes
May 14, 2021
|
This is ready for re-review. The single build failure was a GitHub Actions problem. |
ladyada
approved these changes
May 15, 2021
|
Current modules list from https://circuitpython.readthedocs.io/en/latest/shared-bindings/support_matrix.html (built after this PR merged)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotaryio Trinkey pins were from an older rev board.
Tested with a mounted encoder.
.positionincreases clockwise withIncrementalEncoder(board.ROTA, board.ROTB), as expected. Also testedboard.SWITCHandboard.TOUCH.