Speed up JSON parsing with readinto (#3728 for 6.0.x) #3870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get a chunk of data from readinto instead of a single byte. This speeds up the parsing by reducing the number of function calls. Fixes adafruit#3703
|
I'm thinking maybe this is not worth it because most ESP32-S2 users are on 6.1.x. |
|
It would help other SAMD51 portal projects though. If it's not too much work I think it's worth having. |
|
I tested a very chonky (250kB) .json on ESP32-S2 and it worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #3728 to 6.0.x. It would be great if someone else could test this, because I'm not sure what a good simple test would be.