-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support for Touch Alarm #3850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up fo 10000 r GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Touch Alarm #3850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! Just a couple comments.
I wish my pin alarm PR was already in. I heard you hit the same issue I did. I hope we can figure it out soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tannewt 's requested changes seem to have been addressed. Merging so we can have this in beta3.
I tested this feature with the ESP32S2. |
Ok, the double trigger on touch only seems to occur with the USB connected to computer, but not when on a power supply. So that would be on fake sleep path. Also wake-up speed on touch seems much faster on fake sleep than on real sleep... understandable but should it be better faked? |
Hi @dglaude Thanks for testing this out. Can you please open an issue for this. :-) |
This PR adds support for setting a Touch Alarm.
Port(s) supported: (as of this PR)
Test Code: