8000 Use nina-fw root certs by tannewt · Pull Request #3775 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Use nina-fw root certs #3775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

Use nina-fw root certs #3775

merged 2 commits into from
Dec 2, 2020

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Dec 1, 2020

That way we have one set we use for all of Adafruit's connected
devices.

@tannewt
Use nina-fw root certs
4ac4faa 
That way we have one set we use for all of Adafruit's connected
devices.
@tannewt tannewt added network espressif applies to multiple Espressif chips labels Dec 1, 2020
@tannewt tannewt added this to the 6.1.0 milestone Dec 1, 2020
@tannewt tannewt requested a review from jepler December 1, 2020 01:55
jepler
8000
jepler previously approved these changes Dec 1, 2020
View reviewed changes
Copy link
@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine, but no idea how to test.

@jepler
Copy link
jepler commented Dec 1, 2020

.. except for build failures anyway. doxygen needs to be directed away from the newly added md files?

@tannewt
Copy link
Member Author
tannewt commented Dec 1, 2020

@jepler This is ready. The one failure was transient.

dhalbert
dhalbert approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit 348392f into adafruit:main Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@jepler jepler jepler left review comments

Assignees
No one assigned
Labels
espressif applies to multiple Espressif chips network
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tannewt @jepler @dhalbert
0