enable CIRCUITPY_BLEIO_HCI on non-nRF boards where it will fit #3560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review. Everything passes. I had to make some minor adjustments to makefiles to get the @arturo182 This build does not need nvm. You might want to try this. |
|
Should bleio_hci be built for the grand central_m4? I just built 6.0.0-rc0 and do not see it. |
It should be. Do you mean |
|
never mind -- I forgot to look for the _ --- sorry for the false alarm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boards with plenty of flash have room for the HCI version of
_bleio. Previously this was enabled only for Metro M4 Airlift Lite, but since most any board can use an Airlift breakout, add it to all where it will fit. It is on by default forCIRCUITPY_FULL_BUILD.CIRCUITPY_BLEIO_HCIis not enabled on SAMD21 boards due to size, and not on nRF since they have native BLE.The added size is about 21.3kB.
I'll do this as a draft first to see what fails due to size.