8000 ESP32S2: Enter station mode before connecting by astrobokonon · Pull Request #3489 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

ESP32S2: Enter station mode before connecting #3489

New issue

Have a quest 8000 ion about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2020
Merged

ESP32S2: Enter station mode before connecting #3489

merged 1 commit into from
Sep 30, 2020

Conversation

astrobokonon
Copy link

Closes #3419

It looks like wifi.radio.connect() is missing a call to esp_wifi_set_mode() which is probably why scanning, and then connecting works, but connecting without a scan makes the board wait indefinitely.

Rather than copy the same logic checks to change the mode only if it's different, I just added a call to start_station() and it seems to work as expected. I suppose another fix could be to call esp_wifi_set_mode() in connect().

@tannewt tannewt self-requested a review September 29, 2020 21:52
@tannewt tannewt added bug espressif applies to multiple Espressif chips labels Sep 29, 2020
tannewt
tannewt approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you!

@tannewt tannewt merged commit 7f803c0 into adafruit:main Sep 30, 2020
@astrobokonon astrobokonon deleted the esp32s2-fixconnection branch October 1, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
bug espressif applies to multiple Espressif chips
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP32S2 wifi.radio.connect() depends on scan
2 participants
@astrobokonon @tannewt
0