8000 change esp32s2 CMake verision requirement to >= 3.13 by jerryneedell · Pull Request #3086 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

change esp32s2 CMake verision requirement to >= 3.13 #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2020
Merged

change esp32s2 CMake verision requirement to >= 3.13 #3086

merged 2 commits into from
Jun 28, 2020

Conversation

jerryneedell
Copy link
Collaborator

fixes #3084
Raspberry Pi Raspbian Buster uses CMake v 3.13.4 - this allows building esp32s2 on Raspberry Pi.

Tested on Raspberry Pi 4 B +

@jerryneedell jerryneedell requested a review from jepler June 28, 2020 09:18
@jerryneedell jerryneedell changed the title change CMake verision requirement to >= 3.13 change esp32s2 CMake verision requirement to >= 3.13 Jun 28, 2020
jepler
jepler approved these changes Jun 28, 2020
View reviewed changes
Copy link
@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no testing performed)

@jepler jepler merged commit 5f3843d into adafruit:main Jun 28, 2020
@jerryneedell jerryneedell deleted the jerryn_cmake branch June 28, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake version requirement will not build esp32s2 on Raspberry pi
2 participants
@jerryneedell @jepler
0