Compute USB_DEVICES instead of requiring it to be specified #3038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are already disabled via the USB_DEVICES setting, but the code is included anyway.
|
I think this also has to include the atmel-samd pewpew10 build |
tannewt
previously requested changes
Jun 16, 2020
.. it was not in the USB descriptors anyway (lack of enough endpoints?)
.. it was not in the USB descriptors anyway (lack of enough endpoints?)
.. it was not in the USB descriptors anyway (lack of enough endpoints?)
This makes them all overridable on the board level, tersely
0df3344 to
4933b7a
Compare
Since Actions passed on the previous commit, where this computed value was checked against the specified value (if any), this is no net change, except that we no longer need to specify it for particular boards or ports.
4933b7a to
f232aef
Compare
dhalbert
requested changes
Jun 23, 2020
This restores the ability to remove CDC and/or MSC, at the price of giving up the new automatic check that USB_DEVICES is correct. Since devices have to have CDC and MSC to be "CircuitPython", this is not a facility that is going to be used by any in-tree drivers.
dhalbert
approved these changes
Jun 24, 2020
The CIRCUITPY_USB_yyy disables were added.
This was referenced Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it is possible, it would be nice to avoid the need to change USB_DEVICES when changing CIRCUITPY_USB_HID and ... _MIDI. If #3037 passes CI, then this PR doesn't change anything about available USB devices, it just allows the value to be calculated in all cases.