8000 spresense: Fix port_get_raw_ticks by kamtom480 · Pull Request #2987 · adafruit/circuitpython · GitHub
[go: up one dir, main page]

Skip to content

spresense: Fix port_get_raw_ticks #2987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

kamtom480
Copy link

After #2685 PR, Spresense got stuck in function port_get_raw_ticks after startup. This PR fixes this issue and simplifies getting the number of ticks.

@@ -45,7 +47,8 @@
safe_mode_t port_init(void) {
boardctl(BOARDIOC_INIT, 0);

board_init();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either the call to board_init() should remain, or board_init() should be removed everywhere in this port.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

board_init is called here:

board_init();

Why should we call this function twice?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my mistake, thanks. This was moved in 1004099 but the fix was not applied to cxd56 port.

@jepler jepler merged commit cd5577c into adafruit:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0