nrf: simmel: enable CIRCUITPY_USB_HID #2849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simmel had USB HID disabled in order to save space. However, the board configuration did not set USB_DEVICES, causing it to inherit the default device bouquet of MSC,CDC,MIDI,HID. This in turn caused HID to be included in the USB Configuration Descriptor. For some reason, this was not a problem in an earlier version of tinyusb or circuitpython. However, in the most recent version this has rightfully caused asserts to appear during configuration. Re-enable USB_HID for now, as it doesn't add too much in terms of space. We may disable it again later on if we become pressed for space. Signed-off-by: Sean Cross <sean@xobs.io>
|
Oh great, really fast fidning, I didn't even manage to find the 833 dk in my arsenal yet 😄 . Indeed the tinyusb latest does has some internal improvement for handling drivers lately. |
dhalbert
approved these changes
May 4, 2020
|
Note that I changed the build logic in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simmel had USB HID disabled in order to save space. However, the board
configuration did not set USB_DEVICES, causing it to inherit the default
device bouquet of MSC,CDC,MIDI,HID. This in turn caused HID to be included
in the USB Configuration Descriptor.
For some reason, this was not a problem in an earlier version of tinyusb or
circuitpython. However, in the most recent version this has rightfully
caused asserts to appear during configuration.
Re-enable USB_HID for now, as it doesn't add too much in terms of space.
We may disable it again later on if we become pressed for space.