8000 WIP: add simmel board by xobs · Pull Request #2828 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

WIP: add simmel board #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 30, 2020
Merged

WIP: add simmel board #2828

merged 3 commits into from
Apr 30, 2020

Conversation

xobs
Copy link
@xobs xobs commented Apr 29, 2020

This adds support for Simmel, an nRF52833-based bluetooth tracking
board designed to aid in pandemic tracing.

@xobs
nrf: add simmel board
1d0781b 
This adds support for Simmel, an nRF52833-based bluetooth tracking
board designed to aid in pandemic tracing.

Signed-off-by: Sean Cross <sean@xobs.io>
@xobs xobs mentioned this pull request Apr 29, 2020
Merged
@ladyada
Copy link
Member
ladyada commented Apr 29, 2020

@xobs plz add to the build queue so we can CI :)

Boards missing in .github/workflows/build.yml:
simmel
##[error]Process completed with exit code 1.

@xobs
github: add simmel to build.yml
1327b62 
Signed-off-by: Sean Cross <sean@xobs.io>
@xobs
Copy link
Author
xobs commented Apr 29, 2020

Thanks, added!

@ladyada
Copy link
Member
ladyada commented Apr 29, 2020

@xobs k - when you push the addition, CI will re-run - if it passes we can review :)

@tannewt
Copy link
Member
tannewt commented Apr 29, 2020

Looks like the CI needs to be changed so that it downloads the newer soft device.

@xobs
nrf: bluetooth: add s147 v7.0.1 softdevice hexfile
6aac923 
This was not added as part of the initial v7.0.1 patchset because
.hex files are in this project's .gitignore, and so git ignored it.

Signed-off-by: Sean Cross <sean@xobs.io>
@xobs
Copy link
Author
xobs commented Apr 30, 2020

Ah, the hexfile was in my local repo, but because *.hex is in .gitignore git silently ignored it. Let's try this again.

tannewt
tannewt approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tannewt tannewt merged commit f44e1d6 into adafruit:master Apr 30, 2020
6469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xobs @ladyada @tannewt
0