10000 mimxrt10xx: Enable displayio by arturo182 · Pull Request #2642 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

mimxrt10xx: Enable displayio #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

mimxrt10xx: Enable displayio #2642

merged 1 commit into from
Feb 20, 2020

Conversation

arturo182
Copy link
Collaborator

Closes #2466

@arturo182 arturo182 added the mimxrt10xx iMX RT based boards such as Teensy 4.x label Feb 19, 2020
@arturo182 arturo182 requested a review from tannewt February 19, 2020 21:27
tannewt
tannewt reviewed Feb 20, 2020
View reviewed changes
ports/mimxrt10xx/common-hal/microcontroller/Pin.c
@@ -224,3 +224,7 @@ bool common_hal_mcu_pin_is_free(const mcu_pin_obj_t* pin) {
void common_hal_reset_pin(const mcu_pin_obj_t* pin) {
// reset_pin_number(pin->number);
}

void common_hal_never_reset_pin(const mcu_pin_obj_t* pin) {
// never_reset_pin_number(pin->port, pin->number);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens to the display when the VM finishes? Does it stop working?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the setup right now so can't check, but if we consider the port as WIP then I think it's fine for now, I want to spend more time with the SW soon so will implement this functionality :)

Let's merge as is?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. We have #2486 as a reminder to fix never reset.

tannewt
tannewt approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit a5b7a12 into adafruit:master Feb 20, 2020
@arturo182 arturo182 deleted the imx_displayio branch February 20, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
displayio enhancement mimxrt10xx iMX RT based boards such as Teensy 4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mimxrt10xx: Implement displayio
2 participants
@arturo182 @tannewt
0