Fix alignment warning #2618
Merged
Fix alignment warning #2618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What warning was this giving? I tend to cast (uint8_t*) to uint16_t* or uint32_t* frequently and am surprised this is the only spot you found it. |
|
The problem is the compiler can't tell what alignment the uint8_t in the
call has come in with....so you could have a uint32_t misaligned over the
top of it. In general you'd get away with it no problem, but if you called
this routine with &chararray[1] as the starting point to dump the result
into without this fix it wouldn't be pleasant.
This is with gcc-9 (sorry, not at my desk, so can't tell you exact version)
which has, I think, got considerably more uptight about these things.
Regards
Dave
…On Thu, 13 Feb 2020, 19:16 Scott Shawcroft, ***@***.***> wrote:
What warning was this giving? I tend to cast (uint8_t*) to uint16_t* or
uint32_t* frequently and am surprised this is the only spot you found it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2618?email_source=notifications&email_token=ABJTBD2STNOA3SPFIV2AOG3RCWMCPA5CNFSM4KUFWZZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELWIOCI#issuecomment-585926409>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJTBD4JRZRETR54N4BPA2DRCWMCPANCNFSM4KUFWZZA>
.
|
|
The code looks fine, could've been a memcpy but a loop works too, however the code style doesn't quite match the rest of the file, you use tabs, put opening braces on new line, and are missing spaces around some of the operators :) |
tannewt
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix crowbarring of 32 value into 8 bit register sequence, which was generating an alignment warning.