8000 nrf: i2sout: Fix double-increment when copying samples by jepler · Pull Request #2320 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

nrf: i2sout: Fix double-increment when copying samples #2320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2019
Merged

nrf: i2sout: Fix double-increment when copying samples #2320

merged 2 commits into from
Nov 25, 2019

Conversation

jepler
Copy link
@jepler jepler commented Nov 25, 2019

This caused two problems when playing unsigned samples:

  • When an even number of samples were present, it "worked" but only every other sample was copied into the output, changing the waveform
  • When an odd number of samples were present, the copy continued beyond the end of the buffers and caused a hard fault

This addresses only part of #2255

@jepler
nrf: i2sout: Fix double-increment when copying samples
19d122e 
This caused two problems when playing unsigned samples:
 * When an even number of samples were present, it "worked" but only
   every other sample was copied into the output, changing the waveform
 * When an odd number of samples were present, the copy continued beyond
   the end of the buffers and caused a hard fault
dhalbert
dhalbert requested changes Nov 25, 2019
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jepler jepler force-pushed the nrf-unsigned-audio-crash branch from 5032895 to c9946df Compare November 25, 2019 15:36
@dhalbert dhalbert self-requested a review November 25, 2019 16:42
@dhalbert dhalbert merged commit d154d11 into adafruit:master Nov 25, 2019
@jepler jepler deleted the nrf-unsigned-audio-crash branch November 3, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jepler @dhalbert
0