8000 fix atmel-samd filesystem_tick'ing; clear_temp_status() should check for status indicator in use by dhalbert · Pull Request #2136 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

fix atmel-samd filesystem_tick'ing; clear_temp_status() should check for status indicator in use #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2019
Merged

fix atmel-samd filesystem_tick'ing; clear_temp_status() should check for status indicator in use #2136

merged 1 commit into from
Sep 10, 2019

Conversation

dhalbert
Copy link
Collaborator

Fixes #2114.

  • clear_temp_status() now checks whether status NeoPixel or DotStar is in use.
  • in atmel_samd/tick.c, SysTickHandler() ws not calling filesystem_tick()

There is very similar code in the different versions of ports/*/tick.c which should be factored out eventually into common code. That's part of why the second bug above existed. Since we should rewrite the timing code anyway for #696 (sleep and wakeup), I don't think it's worth refactoring right now.

@dhalbert dhalbert requested a review from tannewt September 10, 2019 03:27
jerryneedell
jerryneedell reviewed Sep 10, 2019
View reviewed changes
Copy link
Collaborator
@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on feather_nrf52840 - works now.
also tested on metro_m4_airlift_lite -- works, but it also worked OK before this PR.

tested at REPL with

import board
import neopixel
pixels = neopixel.NeoPixel(board.NEOPIXEL, 1)
pixels[0] = (255, 0, 0)

@dhalbert
Copy link
Collaborator Author

@jerryneedell Thank you. What was hidden on the atmel-samd boards is that they weren't actually flushing the filesystem promptly, so this fix may help to reduce corrupted filesystems, which was the intent of the code that was working in nrf but not atmel-samd.

tannewt
tannewt approved these changes Sep 10, 2019
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tannewt tannewt merged commit 9d95cc7 into adafruit:master Sep 10, 2019
@dhalbert dhalbert deleted the filesystem-tick-status-fixes branch February 29, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell left review comments

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feather nRF52840 Express Builtin NeoPixel Not Shared Correctly
3 participants
@dhalbert @tannewt @jerryneedell
0