8000 Fix status DotStar writes: fixes DotStar issues on PyRulers by dhalbert · Pull Request #2102 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Fix status DotStar writes: fixes DotStar issues on PyRulers #2102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2019
Merged

Fix status DotStar writes: fixes DotStar issues on PyRulers #2102

merged 1 commit into from
Sep 2, 2019

Conversation

dhalbert
Copy link
Collaborator
@dhalbert dhalbert commented Sep 2, 2019

Fixes #2064. New batch of DotStars on PyRulers didn't work with old code. Previous DotStars were much more tolerant of non-spec writes.

  • Trailing 0xff bytes were omitted in previous DotStar writes. Now 4 are used. Could maybe get away with 1 (Arduino library does, after experimentation), but safer to use 4.
  • Add constant for write buffer size and length of writes. Previously some writes were 8, some were 12.
  • SPI polarity corrected (doesn't work on PyRuler DotStars otherwise).
  • Increased clock speed to 1MHz from 100kHz.

This should provoke another 4.x release sooner or later. The changes should be merged to master after merging to 4.x.

@dhalbert dhalbert added this to the 4.x.x - Bug fixes milestone Sep 2, 2019
ladyada
ladyada approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member
@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test on hardware, but looks good to me!

@dhalbert
Copy link
Collaborator Author
dhalbert commented Sep 2, 2019

Tested on PyRuler (two samples), Trinket M0, Itsy M0, and Itsy M4.

jerryneedell
jerryneedell approved these changes Sep 2, 2019
View reviewed changes
Copy link
Collaborator
@jerryneedell jerryneedell left a comment •
edited
Loading

Choo 8000 se a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on PyRuler and Gemma_M0 == works on both! Also fixes #2037. Yay! Thanks.

@jerryneedell jerryneedell mentioned this pull request Sep 2, 2019
Closed
@dhalbert dhalbert merged commit 67d2e88 into adafruit:4.x Sep 2, 2019
@dhalbert dhalbert deleted the 4.x-dotstar-fix branch September 2, 2019 12:18
This was referenced Sep 2, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@jerryneedell jerryneedell jerryneedell approved these changes

@tannewt tannewt Awaiting requested review from tannewt

@siddacious siddacious Awaiting requested review from siddacious

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.x.x - Bug fixes
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @ladyada @jerryneedell
0