8000 Enable nvm storage for all samd21x18 boards by jrcutler · Pull Request #1687 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Enable nvm storage for all samd21x18 boards #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2019
Merged

Enable nvm storage for all samd21x18 boards #1687

merged 2 commits into from
Mar 27, 2019

Conversation

jrcutler
Copy link
@jrcutler jrcutler commented Mar 24, 2019 •
edited
Loading

Currently, all samd21x18 linker scripts enable 256 bytes of nvm storage except samd21x18-bootloader.ld. As nvm is currently enabled for all samd21x18-bootloader boards (even though CIRCUITPY_INTERNAL_NVM_SIZE is set to 0), I recommend adding a single page of nvm storage for each of these boards.

I have confirmed that the extra 256 bytes does not prevent any of the affected boards from building.

This solves a need for providing some form of configuration memory that lasts across power cycles, as the code required to write to local filesystem for these boards is non-trivial (and generally requires user interaction).

@jrcutler jrcutler changed the title Enable 256b of nvm storage for all samd21x18-bootloader.ld boards. Enable nvm storage for all samd21x18 boards Mar 24, 2019
@jrcutler
Copy link
Author

It looks like I need to test again, as I didn't try non-EN builds.

@dhalbert
Copy link
Collaborator
dhalbert commented Mar 24, 2019 •
edited
Loading

de_DE is the largest. It was fr for a while, but de_DE is more up to date and has more strings right now.

@jrcutler
Copy link
Author

It appears that catwan_usbstick is the only samd21 that isn't disabling CIRCUITPY_FREQUENCYIO (which requires more than 5.5kB).

According to the Circuitpython documentation, frequencyio is not supported on samd21 boards.

Does the catwan_usbstick need this undocumented support, or was the omission of CIRCUITPY_FREQUENCYIO = 0 an accident?

@dhalbert
Copy link
Collaborator
dhalbert commented Mar 24, 2019 •
edited
Loading

It's almost certainly an accident. frequencyio may have been added after the catwan board was added. Just disable it like the other samd21 boards.

@jrcutler
Copy link
Author

I just checked the CatWAN USB Stick Circuitpython example, and they do not appear to rely on frequencyio.

@sommersoft
Copy link

It appears that catwan_usbstick is the only samd21 that isn't disabling CIRCUITPY_FREQUENCYIO

Ooops! Looks like I missed that one when I put in the PR for frequencyio.

Just needs CIRCUITPY_FREQUENCYIO = 0 placed in the CatWAN's mpconfigboard.mk file. I can submit it if not included elsewhere.

@tannewt tannewt requested a review from dhalbert March 26, 2019 23:10
dhalbert
dhalbert approved these changes Mar 27, 2019
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; let's do it!

@dhalbert dhalbert merged commit df79e9a into adafruit:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrcutler @dhalbert @sommersoft
0