8000 enable MICROPY_CPYTHON_COMPAT for most builds except CIRCUITPY_SMALL_BUILD by dhalbert · Pull Request #1675 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

enable MICROPY_CPYTHON_COMPAT for most builds except CIRCUITPY_SMALL_BUILD #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

B 8000 y clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2019
Merged

enable MICROPY_CPYTHON_COMPAT for most builds except CIRCUITPY_SMALL_BUILD #1675

merged 2 commits into from
Mar 20, 2019

Conversation

dhalbert
Copy link
Collaborator

Remove a few other things to allow it to fit on boards with frozen modules.

Clean up a few other feature settings.

Starting with a draft PR to see that everything builds.

@dhalbert
enable MICROPY_CPYTHON_COMPAT for most builds except CIRCUITPY_SMALL_…
fbf166a 
…BUILD; remove a few other things to make fit
@dhalbert
Copy link
Collaborator Author

OK, bleah, draft PR's don't run travis, so I'll make it not a draft.

@dhalbert dhalbert marked this pull request as ready for review March 20, 2019 18:40
@dhalbert dhalbert requested a review from tannewt March 20, 2019 21:09
@dhalbert
Copy link
Collaborator Author

Travis is now happy. Fixes #1437.

tannewt
tannewt approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member
@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Glad to have compatibility back.

@tannewt tannewt merged commit 6f288eb into adafruit:master Mar 20, 2019
@tannewt tannewt mentioned this pull request Mar 20, 2019
Closed
@dhalbert dhalbert deleted the cpython-compat branch May 28, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt
0