flush flash filesystem once a second #1672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Mar 20, 2019
That's a good idea. I'll add that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds timing code to flush the flash filesystem once a second (if needed). The interval can be varied by a compile constant.
I think this would solve any remaining file-flushing issues. But there may be other issues causing a hard crash that will corrupt the filesystem if they occur during a write, and this won't fix those.
I have done limited testing. I saw one safe-mode reboot on PyPortal that may have been unrelated to the filesystem.
Tagging @makermelissa and @uhrheber on this.