8000 adjust SAMD51 neopixel_write timing by jerryneedell · Pull Request #1141 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

adjust SAMD51 neopixel_write timing #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to 8000 our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2018
Merged

adjust SAMD51 neopixel_write timing #1141

merged 1 commit into from
Aug 24, 2018

Conversation

jerryneedell
Copy link
Collaborator

This works with the "onboard" neopixels on a metro_m4_express and feather_m4 express. It also works with the RGBW 8 pixel strip using VUSB and D5(5v) on my itsy_bitsy_m4_express.
I also tested running a "jewel" and the strip at 3V on the metro_m4_express. both worked.

I measured the write frequency on the itsybitsy_m4_express and saw ~757kHz

@jerryneedell jerryneedell requested a review from tannewt August 24, 2018 11:19
@jerryneedell jerryneedell mentioned this pull request Aug 24, 2018
Closed
@jerryneedell
Copy link
Collaborator Author
jerryneedell commented Aug 24, 2018 •
edited
Loading

I am not able to read the error report from Travis? Is it working? Can anyone tell me what failed?
I tried just restarting the build --- waiting....
Finally -- Travis passed - after a few restarts

dhalbert
dhalbert approved these changes Aug 24, 2018
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the thorough testing! I'll have the OP test as well.

@dhalbert dhalbert merged commit caa2328 into adafruit:3.x Aug 24, 2018
@tannewt
Copy link
Member
tannewt commented Aug 24, 2018

Thanks @jerryneedell !

@dhalbert
Copy link
Collaborator

fixes #1140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryneedell @tannewt @dhalbert
0