8000 Reduce pin object size by removing the QSTR by tannewt · Pull Request #1082 · adafruit/circuitpython · GitHub
[go: up one dir, main page]
Skip to content

Reduce pin object size by removing the QSTR #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally 8000 send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2018
Merged

Reduce pin object size by removing the QSTR #1082

merged 2 commits into from
Aug 2, 2018

Conversation

tannewt
Copy link
Member
@tannewt tannewt commented Aug 2, 2018

We also now use the version from the peripherals library. It renames the pin number field from pin to number.

tannewt added 2 commits August 2, 2018 13:59
@tannewt
Move pin struct to the peripherals library.
168aa39 
Its slimmed down by removing the qstr and bit packing TCC info.

The trinket m0 build actually grows by 20 bytes. The arduino zero
build shrinks by 188 bytes.
@tannewt
Update to peripherals merge.
64e5691
@tannewt tannewt requested a review from dhalbert August 2, 2018 21:07
dhalbert
dhalbert approved these changes Aug 2, 2018
View reviewed changes
Copy link
Collaborator
@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, I like this! pin->pin was always hard to read. And now printing pins, etc. Great! Will merge after travis.

@dhalbert dhalbert merged commit 88ae7a9 into adafruit:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
atmel-samd memory optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert
0